Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failOnSevere #12

Closed
wants to merge 8 commits into from
Closed

Conversation

coilysiren
Copy link

adds:

  • failOnSevere config for failing on 'severe' error messages

like #11 except,

  • failOnSevere instead of failOnMessage
  • adds tests
  • updates readme

@coilysiren
Copy link
Author

Changing the flag to failOnSevere was to mirror protractor-console-plugin more closely

I want to add failOnWarning too, but first I want to figure out why the level here is called severe instead of error

@coilysiren
Copy link
Author

coilysiren commented May 17, 2018

PR isn't ready actually!!! I need to make the addFailure actually work (there's a test in there already for asserting that it exists, which currently it does not)

@coilysiren
Copy link
Author

Figured it out 🙂 although now I'm wishing everything was written with type annotations

@pmowrer
Copy link
Contributor

pmowrer commented May 17, 2018

Thanks for the great contribution @lynncyrin! Would you mind also updating the package.json version (probably 3.1.0 since this is a new feature) and an entry to the CHANGELOG?

@coilysiren
Copy link
Author

So it turns out that I ended up not needing this, and moved on to other things! Someone else is free to grab taking this across the finish line

@coilysiren coilysiren closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants